done v1 #5109
done v1 #5109
Conversation
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 However, there are a few critical issues that need to be addressed to meet the core requirements of the task. Specifically, the implementation is missing the stars BEM block, SCSS variables, and the required file structure. Additionally, the background-image path and font usage need to be verified against the task specifications. Please make these changes, and feel free to reach out if you need any help. Keep up the great effort! 🌟
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
There was a problem hiding this comment.
Great effort on your project! 🎉 While your code is generally well-structured and organized, there are a few critical issues that need attention to fully meet the task requirements:
-
Missing
starsBEM Block: ThestarsBEM block is not included in your implementation. This block should be rewritten from the Stars task using SCSS and included in both your HTML and SCSS files. -
SCSS Variables: While you have used SCSS variables for main values like colors, consider expanding their use to include other repeated values such as
font-family,background-color, andborder-colorfor better maintainability. -
File Structure: Ensure that your file structure aligns with the task requirements. The
starsblock should be in its own SCSS file, and theindex.cssfile should be removed if not required. -
Background Image Path: Verify and adjust the
background-imagepath to ensure it is relative toindex.scssand starts with../images. -
Stylesheet Path: Double-check that the stylesheet path is correct and that the
index.cssfile contains all necessary styles and SCSS variables as per the task description.
Your decision to approve this pull request is to help you move forward with your learning. Please review the comments carefully and address these issues in your future work to avoid similar problems. Keep up the good work and continue improving your code! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
src/index.html
Outdated
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Product cards</title> | ||
| <link href="https://fonts.googleapis.com/css2?family=Roboto:wght@400;700&display=swap" rel="stylesheet" /> | ||
| <link rel="stylesheet" href="./styles/index.css" /> |
There was a problem hiding this comment.
Ensure that the stylesheet path is correct and aligns with the task requirements. Verify that the index.css file contains the necessary styles and SCSS variables as per the task description.
src/index.html
Outdated
| </head> | ||
| <body> | ||
| <h1>Product cards</h1> | ||
| <div class="product-card" data-qa="card"> |
There was a problem hiding this comment.
The stars BEM block is missing. According to the task requirements, this block should be included in the HTML structure.
| @@ -0,0 +1,68 @@ | |||
| body { | |||
| margin: 0; | |||
| font-family: Roboto, sans-serif; | |||
There was a problem hiding this comment.
Consider using SCSS variables for the font family and other repeated values to enhance maintainability and consistency across your styles.
|
|
||
| .product-card { | ||
| width: 200px; | ||
| background-color: #fff; |
There was a problem hiding this comment.
Consider using SCSS variables for colors like background-color and border-color to make it easier to manage and update these values.
src/styles/index.css
Outdated
| } | ||
| .product-card__button { | ||
| padding: 8px 16px; | ||
| background-color: #007bff; |
There was a problem hiding this comment.
Consider using SCSS variables for colors like background-color to make it easier to manage and update these values.
src/styles/index.scss
Outdated
| background-color: $hover-color; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
The stars BEM block is missing. According to the task requirements, this block should be included and styled in the SCSS file.
No description provided.