Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add task solution #5108

Closed
wants to merge 2 commits into from
Closed

add task solution #5108

wants to merge 2 commits into from

Conversation

olhakostovetska
Copy link

mateacademy-ai-mentor
mateacademy-ai-mentor suggested changes Dec 23, 2024
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are a few critical issues that need to be addressed before we can proceed. The task requires the use of two separate BEM blocks (card and stars), each in their own file, and SCSS variables should be used and placed in a separate file. Additionally, the stars block should be rewritten from the Stars task with SCSS. Let's make these adjustments to fully meet the task requirements. You're doing great, and with these changes, your solution will be even better! 🌟 Keep up the good work!

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olhakostovetska @mateacademy-ai-mentor