Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

product card #5106

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Manuilenkoart
Copy link

@Manuilenkoart Manuilenkoart commented Dec 23, 2024

  • DEMO LINK

  • TEST REPORT LINK

  • there 2 BEM blocks card and stars each in their own file

  • SCSS Nesting is used for elements, modifiers and pseudo-classes

  • SCSS Variables are used for main values and placed in a separate file

  • all stars--N modifiers work as expected (Highlight first N stars)

  • Code follows all the Code Style Rules ❗️

  • there 2 BEM blocks card and stars each in their own file

  • SCSS Nesting is used for elements, modifiers and pseudo-classes

  • SCSS Variables are used for main values and placed in a separate file

  • all stars--N modifiers work as expected (Highlight first N stars)

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code has been reviewed and meets the majority of the task requirements and constraints. 🎉 Great job on structuring your HTML and SCSS files effectively! Here are some key points from the review:

  • SCSS Variables: You've correctly created and used the variables.scss file, enhancing maintainability and consistency.
  • BEM Blocks: The card and stars blocks are implemented as required, with separate SCSS files.
  • SCSS Nesting: Proper use of nesting for elements, modifiers, and pseudo-classes is evident.
  • Attributes: The data-qa attributes are correctly added to the card and link elements.
  • Image Paths: Background image paths are correctly set relative to index.scss.
  • Font and Styles: The Google Font is included, and default browser margins are reset.
  • Card and Link Styles: The card width is set as specified, and link styles change on hover.

While there are no critical issues, please ensure to review the comments to further improve your code. This decision is made to help you move forward with your learning. Keep up the great work, and continue to refine your skills! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

@Manuilenkoart Manuilenkoart changed the title Update product card layout and styles; upgrade @mate-academy/scripts … product card Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants