Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update product card layout and styles; upgrade @mate-academy/scripts … #5101

Closed
wants to merge 4 commits into from

Conversation

Manuilenkoart
Copy link

  • there 2 BEM blocks card and stars each in their own file
  • SCSS Nesting is used for elements, modifiers and pseudo-classes
  • SCSS Variables are used for main values and placed in a separate file
  • all stars--N modifiers work as expected (Highlight first N stars)
  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


It looks like there are a few critical issues that need to be addressed before we can approve this pull request:

  1. Undefined SCSS Variables: The variables $blue-accent, $color-main, and $color-secondary are used but not defined in your SCSS setup. This will lead to errors during compilation. Please ensure these variables are defined in your variables.scss or another appropriate file.

  2. SCSS Compilation: The SCSS file is being linked directly in the HTML, which is not standard practice. Ensure that Parcel is set up to compile your SCSS into CSS, and link the resulting CSS file in your HTML instead. This will help maintain compatibility across different browsers and ensure proper styling.

Once these issues are resolved, your code will be in great shape! Keep up the good work, and feel free to reach out if you have any questions or need further assistance. 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

src/index.html Show resolved Hide resolved
src/styles/card.scss Show resolved Hide resolved
src/styles/card.scss Show resolved Hide resolved
src/styles/card.scss Show resolved Hide resolved
src/styles/card.scss Show resolved Hide resolved
src/styles/card.scss Show resolved Hide resolved
src/styles/card.scss Show resolved Hide resolved
src/styles/card.scss Show resolved Hide resolved
src/styles/card.scss Show resolved Hide resolved
@Manuilenkoart Manuilenkoart deleted the develop branch December 23, 2024 16:44
@Manuilenkoart Manuilenkoart restored the develop branch December 23, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants