Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEMO LINK](https://MariannaBo.github.io/js_2048_game/) #580

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MariannaBo
Copy link

No description provided.

@MariannaBo
Copy link
Author

DEMO LINK

Copy link

@loralevitska loralevitska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • we still have a step to the right
    image
    please fix it
  • try to avoid such nesting (use helper function)
    image

loseMessage.classList.add('hidden');
}

if (!winMessage.classList.contains('hidden')) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repeatable code can be moved to the helper function

Copy link

@volodymyr-soltys97 volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants