Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

game2048 #577

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

game2048 #577

wants to merge 4 commits into from

Conversation

MariiaSuper
Copy link

@MariiaSuper MariiaSuper commented Nov 15, 2023 •
edited
Loading

maxim2310
maxim2310 suggested changes Nov 15, 2023
View reviewed changes
Copy link

@maxim2310 maxim2310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, but lets make some improvement
now i can click in in one direction(right for example) even if i shouldnt and blocks appears, check it and fix please

src/scripts/game_logic.js Outdated Show resolved Hide resolved
xiimiik
xiimiik suggested changes Nov 16, 2023
View reviewed changes
Copy link

@xiimiik xiimiik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can start the game by press any the keyboard arrow, but the "Start" button remains active, that is, I can start the game in the middle of the game, but not click "Restart"

@MariiaSuper MariiaSuper requested a review from xiimiik November 16, 2023 12:07
xiimiik
xiimiik approved these changes Nov 16, 2023
View reviewed changes
Copy link

@xiimiik xiimiik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiimiik xiimiik xiimiik approved these changes

@maxim2310 maxim2310 Awaiting requested review from maxim2310

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MariiaSuper @maxim2310 @xiimiik