Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task solution #1146

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Task solution #1146

wants to merge 5 commits into from

Conversation

Poviakalo
Copy link

@Poviakalo Poviakalo commented Jan 23, 2025 •
edited
Loading

etojeDenys
etojeDenys suggested changes Jan 23, 2025
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget to fix the demo link and then re-request the review

@Poviakalo
Copy link
Author

My project wasn't built. But I've fixed that problem. Could you check it again?

@Poviakalo Poviakalo requested a review from etojeDenys January 24, 2025 11:00
etojeDenys
etojeDenys suggested changes Jan 24, 2025
View reviewed changes
Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

demo link still doesn't work
image

@Poviakalo
Copy link
Author

Please, check the link one more time. Everything is well.

@Poviakalo Poviakalo requested a review from etojeDenys January 24, 2025 15:58
vadiimvooo
vadiimvooo approved these changes Jan 24, 2025
View reviewed changes
Copy link

@vadiimvooo vadiimvooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadiimvooo vadiimvooo vadiimvooo approved these changes

@etojeDenys etojeDenys Awaiting requested review from etojeDenys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Poviakalo @etojeDenys @vadiimvooo