Adaptive import option #280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the document count
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 8.x #280 +/- ##
======================================
Coverage ? 98.01%
Complexity ? 259
======================================
Files ? 40
Lines ? 808
Branches ? 0
======================================
Hits ? 792
Misses ? 16
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
Not sure about it. A dev could decide itself by running with or without parallel. I mean speed could depends on setup like machine number of parallel queues, IO performance. So 75000 it's for your setup |
|
Closing this PR for now, as the performance is highly dependent on the machines hardware specs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on some performance testing (here), I have added an 'adaptive' import option. That will check if parallel import is 'worth it' in that case.
Useful when having multiple imports going, with varying document count.
This is still a work in progress, would like your opinion if this is even something that should be added, or should just be kept under the same '--parallel' option.
Things to do:
Check Queue::size of the parallel-import queues, if they are full or currently handling another import - disable parallel import.
More performance testing, as the number of documents where parallel import is faster than regular could vary.