using localhost instead of 0.0.0.0 for server-startup check #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t in the HTTP call and retry
…this will fail on certain linuxes. It should be sufficient to connect to the loopback interface for these purposes
…erver_to_die work similarly
…may want to configure it externally
matadon
added a commit
that referenced
this pull request
Dec 8, 2012
Exponential fall-off for timeouts, as well as attempting to connect to localhost when the server is listening on all interfaces (fixes a bug in CentOS). For more information, see issue #27.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a specific hostname is not specified for the server startup via the -o switch, the server starts up glomming to all interfaces (0.0.0.0). This same behaviour is problematic for the wait_for_server and wait_for_server_to_die methods on CentOS 6 (and I am guessing RHEL) - as Net::HTTP cannot connect to 0.0.0.0 by default on these systems. This means that the startup script never finishes.
For these cases, when the host is 0.0.0.0, the wait_for_server and wait_for_server_to_die methods could just use the loopback interface directly. This change allows the script to launch and daemonize the server correctly on these systems.