Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken open-setting sub command #119

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Fix broken open-setting sub command #119

merged 1 commit into from
Oct 31, 2023

Conversation

masutaka
Copy link
Owner

$ github-nippou open-settings でブラウザの反応がなくなってた。

なんだろう?と調べたら、401 Bad credentials が返っており、settings.Init() の第2引数に渡すべき accessToken が空文字列になっていた。

if err := settings.Init(getGistID(), ""); err != nil {
return nil
}

v4.2.5 からのエンバグ。PR #11602eb6c0 だったのね。

@MH4GF: レビューで漏れてて申し訳なかったです。:pray:

@masutaka masutaka added the bug label Oct 31, 2023
@masutaka masutaka self-assigned this Oct 31, 2023
@masutaka
Copy link
Owner Author

accessToken は OpenSettings() に渡すことも考えたけど、この関数は実質 CLI 専用なので、これで良いと思いました。

@masutaka masutaka merged commit 3d6cee5 into master Oct 31, 2023
4 checks passed
@masutaka masutaka deleted the fix-open-setting branch October 31, 2023 03:22
@masutaka
Copy link
Owner Author

🚀 v4.2.6

@MH4GF
Copy link
Contributor

MH4GF commented Oct 31, 2023

@masutaka なんと...!申し訳ないです 🙏🏻
対応ありがとうございます!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants