This repository has been archived by the owner on Jan 14, 2022. It is now read-only.
Alter the API of Salmon related functions #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit has the following significant changes for the API * Rename symbols with the name the specification uses. * Introduce MagicEnvelope object in favor of reuse of parsed information and simplicity. * Add a method to decode magic public key.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit has the following significant changes for the API
MagicEnvelopeobject in favor of reuse of parsed information and simplicity.Question
I interpreted the intension of having
magic_key_to_peminstead of a method just returningOpenSSL::PKey::RSAas it is expected to prevent from depending on the API ofOpenSSL::PKey::RSA. However, the oldOStatus2::Salmon::verifyactually depends on it.Can the API of OStatus2 depend on the API of
OpenSSL::PKey::RSA, or should it not?