Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a workflow to auto-update generated files #853

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

j-f1
Copy link
Contributor

@j-f1 j-f1 commented Jan 3, 2023

This workflow runs on the automatically generated (?) PRs from Crowdin like #804, runs ./update_localization.sh, and pushes the result. This avoids a situation where the generated files are out of sync with the latest localization strings. Since it only runs on the l10n_develop branch, any code changes it makes can be reviewed as part of the normal code review process — it won’t make changes to main.

@CLAassistant
Copy link

CLAassistant commented Jan 3, 2023

CLA assistant check
All committers have signed the CLA.

@j-f1 j-f1 force-pushed the auto-update-l10n branch from 289add1 to 23a1bca Compare January 3, 2023 13:53
@j-f1
Copy link
Contributor Author

j-f1 commented Jan 7, 2023

Not sure if there’s a way to fix the above issue. Willing to attribute the commit to a human but ideally bots could be exempted from the CLA

@j-f1 j-f1 force-pushed the auto-update-l10n branch from 23a1bca to 16f7926 Compare March 28, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants