Skip to content

Commit

Permalink
Merge branch 'develop' into plugin_preservetombs
Browse files Browse the repository at this point in the history
  • Loading branch information
master-spike committed Oct 1, 2023
2 parents a8e09ac + 211b34c commit f7fd769
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 12 deletions.
13 changes: 7 additions & 6 deletions docs/changelog.txt
Original file line number Diff line number Diff line change
Expand Up @@ -59,23 +59,24 @@ Template for new versions:
## New Features

## Fixes
- `autolabor`: now unconditionally re-enables vanilla work details when the fort or the plugin is unloaded
- `autolabor`: ensure vanilla work details are reinstated when the fort or the plugin is unloaded
- ``dfhack.TranslateName()``: fixed crash on certain invalid names, which affected `warn-starving`
- EventManager: Unit death event no longer misfires on units leaving the map

## Misc Improvements
- `dig`: `digtype` command now has options to choose between designating only visible tiles or hidden tiles, as well as "auto" dig mode. Z-level options adjusted to allow choosing z-levels above, below, or the same as the cursor.
- `digtype`: designate only visible tiles by default, and use "auto" dig mode for following veins
- `digtype`: added options for designating only current z-level, this z-level and above, and this z-level and below
- `hotkeys`: make the DFHack logo brighten on hover in ascii mode to indicate that it is clickable
- `hotkeys`: use vertical bars instead of "!" symbols for the DFHack logo to make it easier to read
- EventManager: guarded against potential iterator invalidation if one of the event listeners modified the global data structure being iterated over
- EventManager: changed firing order of building created and building destroyed events to improve performance in the building location cache.
- `hotkeys`: use vertical bars instead of "!" symbols for the DFHack logo in ascii mode to make it easier to read
- EventManager: guard against potential iterator invalidation if one of the event listeners were to modify the global data structure being iterated over
- EventManager: for ``onBuildingCreatedDestroyed`` events, changed firing order of events so destroyed events come before created events

## Documentation

## API

## Lua
- mouse key events are now aligned with internal DF semantics: ``_MOUSE_L`` indicates that the left mouse button has just been pressed and ``_MOUSE_L_DOWN`` indicates that the left mouse button is being held down. similar for ``_MOUSE_R`` and ``_MOUSE_M``. 3rd party scripts may have to adjust.
- mouse key events are now aligned with internal DF semantics: ``_MOUSE_L`` indicates that the left mouse button has just been pressed and ``_MOUSE_L_DOWN`` indicates that the left mouse button is being held down. similarly for ``_MOUSE_R`` and ``_MOUSE_M``. 3rd party scripts may have to adjust.

## Removed

Expand Down
15 changes: 12 additions & 3 deletions library/lua/gui/dialogs.lua
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,10 @@ function MessageBox:onInput(keys)
gui.markMouseClicksHandled(keys)
return true
end
return self:inputToSubviews(keys)
if self:inputToSubviews(keys) then
gui.markMouseClicksHandled(keys)
return true
end
end

function showMessage(title, text, tcolor, on_close)
Expand Down Expand Up @@ -137,7 +140,10 @@ function InputBox:onInput(keys)
gui.markMouseClicksHandled(keys)
return true
end
return self:inputToSubviews(keys)
if self:inputToSubviews(keys) then
gui.markMouseClicksHandled(keys)
return true
end
end

function showInputPrompt(title, text, tcolor, input, on_input, on_cancel, min_width)
Expand Down Expand Up @@ -239,7 +245,10 @@ function ListBox:onInput(keys)
gui.markMouseClicksHandled(keys)
return true
end
return self:inputToSubviews(keys)
if self:inputToSubviews(keys) then
gui.markMouseClicksHandled(keys)
return true
end
end

function showListPrompt(title, text, tcolor, choices, on_select, on_cancel, min_width, filter)
Expand Down
2 changes: 1 addition & 1 deletion library/xml
Submodule xml updated 1 files
+2,964 −0 symbols.xml
2 changes: 1 addition & 1 deletion plugins/lua/orders.lua
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ function OrdersOverlay:init()
widgets.HotkeyLabel{
frame={t=0, l=15},
label='recheck',
key='CUSTOM_CTRL_R',
key='CUSTOM_CTRL_K',
auto_width=true,
on_activate=do_recheck,
},
Expand Down
2 changes: 1 addition & 1 deletion scripts

0 comments on commit f7fd769

Please sign in to comment.