Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DP-29047: Style fix - remove horiz rule on mobile on info detail page for cards #1833

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions changelogs/DP-29047.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
# Every PR must have a changelog. To create a changelog:
# 1. Make a copy of this file and name it with the ticket number.
# 2. Keep the original format of one of the examples at the bottom, and override each element of it using ___TEMPLATE___ for reference
# 3. Remove all comments from the copied file

#___CHANGE TYPES___
# - Added for new features.
# - Changed for changes in existing functionality.
# - Deprecated for soon-to-be removed features.
# - Removed for now removed features.
# - Fixed for any bug fixes.
# - Security in case of vulnerabilities.
# e.g. Added

#___PROJECT___
# - Patternlab
# - React
# - Docs
# e.g. React
# e.g. React, Patternlab

#___COMPONENT___
# Component name(s) in `PascalCase`
# e.g. Header
# e.g. Form, InputSlider, InputTextTypeAhead

#___DESCRIPTION___
# PR description and PR number (append PR number with # to create a link to the PR in Github)
# If you need multiple lines, start the first line with the following "|-" characters.
# For any breaking changes, add a comment in the PR describing the necessary changes on the consumer side and link that comment in the description.
#e.g. Adds apples to apple trees for admin apple pickers (#PR)

#___ISSUE___
# A Jira ticket or a Github issue number (append Github issue number with # to create a link to the issue in Github)
# e.g. DP-12345 or #123

#___IMPACT___
# - Major impact when you make incompatible API changes,
# - Minor impact when you add functionality in a backwards compatible manner, and
# - Patch impact when you make backwards compatible bug fixes.
# e.g. Minor
# See https://semver.org/ for more info.


#___TEMPLATE___
# ChangeType [enter a valid option, see __CHANGE TYPES___ e.g. Added]:
# - project: Enter one or multiple (comma separated) valid project prefix(es) - see ___PROJECT___ e.g. React, Patternlab
# component: Enter one or multiple (comma separated) valid component name(s) - see ___COMPONENT___ e.g. Color
# description: Describe the change and add the PR number. see ___DESCRIPTION___ e.g. Adds apples to apple trees for admin apple pickers (#PR)
# issue: Add a Jira ticket or issue number, e.g. DP-12345 or 124
# impact: Enter a valid impact, e.g. Minor

#___EXAMPLE___
Fixed:
- project: Patternlab
component: SectionLinks
description: Style fix - remove horiz rule on mobile on info detail page for cards. (#1833)
issue: DP-29047
impact: Patch
2 changes: 1 addition & 1 deletion packages/assets/scss/02-molecules/_section-links.scss
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@
}

&__mobile-title {
border-bottom-color: $c-bd-divider;
border-bottom-color: transparent;

svg {
fill: rgba($c-font-link,.5);
Expand Down