Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare isExpired to pass a margin for slower scenarios #20

Merged
merged 8 commits into from
Oct 24, 2024

Conversation

sebastianvarela
Copy link
Collaborator

PR's key points

Prepare isExpired to pass a margin for slower scenarios

@ThorBot
Copy link

ThorBot commented Oct 23, 2024

6 Messages
📖 Mini-iOSTests: Executed 68 tests, with 0 failures (0 expected) in 11.265 (11.265) seconds
📖 Mini-macOSTests: Executed 68 tests, with 0 failures (0 expected) in 11.304 (11.304) seconds
📖 Mini-tvOSTests: Executed 68 tests, with 0 failures (0 expected) in 11.396 (11.396) seconds
📖 ⌛️ [output] Slowest test: test_check_expiration_for_custom took 4.010 seconds
📖 ⌛️ [output] Slowest test: test_check_expiration_for_custom took 4.061 seconds
📖 ⌛️ [output] Slowest test: test_check_expiration_for_custom took 4.070 seconds

SwiftLint found issues

Warnings

File Line Reason
Dispatcher.swift 75 Returning Void in a function declaration is redundant (redundant_void_return)
None.swift 4 This default initializer would be synthesized automatically - you do not need to define it (unneeded_synthesized_initializer)
Publishers.CombineMiniTasksTuple3.swift 81 Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
Publishers.CombineMiniTasksTuple3.swift 91 Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
Publishers.CombineMiniTasksTuple4.swift 86 Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
Publishers.CombineMiniTasksTuple4.swift 97 Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
Publishers.CombineMiniTasksTuple2.swift 76 Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
Publishers.CombineMiniTasksTuple2.swift 85 Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
PublishersTests+MapToLatestTask.swift 22 Prefer implicit returns in closures, functions and getters (implicit_return)
PublishersTests+MapToLatestTask.swift 65 Prefer implicit returns in closures, functions and getters (implicit_return)
PublishersTests+MapToLatestTask.swift 87 Prefer implicit returns in closures, functions and getters (implicit_return)
PublishersTests+MapToLatestTask.swift 111 Prefer implicit returns in closures, functions and getters (implicit_return)
PublishersTests+MapToLatestTask.swift 136 Prefer implicit returns in closures, functions and getters (implicit_return)
PublishersTests+MapToLatestTask.swift 161 Prefer implicit returns in closures, functions and getters (implicit_return)
TestInterceptor.swift 26 Returning Void in a function declaration is redundant (redundant_void_return)
DispatcherTests.swift 12 Returning Void in a function declaration is redundant (redundant_void_return)
DispatcherTests.swift 13 Returning Void in a function declaration is redundant (redundant_void_return)

Generated by 🚫 Danger

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.95%. Comparing base (806b4e6) to head (4ae1efb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage   93.81%   93.95%   +0.13%     
==========================================
  Files          45       45              
  Lines        2409     2415       +6     
==========================================
+ Hits         2260     2269       +9     
+ Misses        149      146       -3     
Flag Coverage Δ
ios 93.83% <100.00%> (+0.13%) ⬆️
mac 93.95% <100.00%> (+0.13%) ⬆️
tv 93.83% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Gabriel-V-Radu
Gabriel-V-Radu previously approved these changes Oct 24, 2024
@josemanuelmartin josemanuelmartin merged commit 4797f57 into master Oct 24, 2024
4 checks passed
@josemanuelmartin josemanuelmartin deleted the task/fix_expired branch October 24, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants