Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of non-latin nicks #523

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ypeskov
Copy link

@ypeskov ypeskov commented Sep 17, 2017

Hi,

I found an issue when some event are occurring with a user whose nick consists from non Latin characters, it cannot be parsed and as a result it is undefined in such event like "join".

Here is a possible solution

@Throne3d
Copy link

Throne3d commented Oct 18, 2020

I realize this PR has been open for a long time, but just in case anyone stumbles across it and wants support for a wider variety of nicknames, my long-time fork of this repo (irc-upd on npm) has a more comprehensive regex here to parse usernames, as well as some quick tests for the usernames 견본, x/y, and ?nick. It might be worth considering!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants