Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user modes updating #426

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

zephrax
Copy link
Contributor

@zephrax zephrax commented Nov 2, 2015

The user modes inside "channel.users" structure was not being updated. The comparison wasn't returning the expected value, so I changed it a little. Now the user modes are being updated successfuly.

@moshmage
Copy link

moshmage commented Nov 5, 2015

I'm not too fond of if (typeof channel.users[user] !== 'undefined') these kinds of checks, false is not undefined but it doesn't hold and value to be replaced either.

checking for its length, though, does seem safe enough: if it has length, it has things inside.

@ward
Copy link

ward commented Mar 28, 2016

This was rewritten in PR #351 and now functions correctly as far as I can tell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants