Add regexp for Japanese and Korean nicknames. #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And as per the RFC Nicknames can't start with numbers, only letters or special chars [which I'm not certain of which] |
|
+1 For this PR. If current IRC spec does not support CJK nicknames, why don't we at least opt-in this feature? |
|
+1 for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some IRC servers support unicode, and even for nicknames.
The message handler receives an 'undefined' sender name if its name contains unicode characters.
I tried to add all non-special unicode characters,
but I couldn't find any better ways than adding character range manually.
Also, I wander why there is a trailing '-' inside the [] block.
Isn't '-' implies character ranges?
Sorry for some incomplete opinions.
(This is my first time doing with js:)