Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements a (something)more robust encode conversion module #387

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

aurium
Copy link

@aurium aurium commented Jul 24, 2015

Helps the users to survive the fail of C modules, named: iconv

This module also provide a handily interface to detect and convert charsets.

Aurélio A. Heckert added 12 commits July 24, 2015 20:46
Helps the users to survive the fail of C modules, named: `iconv` and `node-icu-charset-detector`

This module also provide a handily interface to detect and convert charsets.
`node-icu-charset-detector` and `jschardet` charset name responses are not compatible.
Selecting `jschardet` by being pure JS and an alive project.
Do not mess tests on iojs.
@jirwin
Copy link
Collaborator

jirwin commented Jul 27, 2015

I'd much rather see lib/encode.js be a separate module that node-irc depends on. Ideally we wouldn't have to install a system package to get this working either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants