Add localPort connection option to specify socket bind port #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connecting. node v0.11.13+
|
Hi @m4rcelofs. Can you please add tests to this? Thank you! |
ghost
added
the
|
@apeiron Could you please elaborate on what should be tested? It's just an added parameter to net.createConnection. |
|
@m4rcelofs A simple test that validates that the config gets set and is used is sufficient. You should be able to introspect the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... when connecting, the same way it's done with localAddress.
Node added support for this on v0.11.13+, see issue 7092