Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exports codes & parseMessage #290

Closed
wants to merge 1 commit into from
Closed

exports codes & parseMessage #290

wants to merge 1 commit into from

Conversation

hnry
Copy link

@hnry hnry commented Jan 11, 2015

Export codes & parseMessage ( the parser ) so users can have more access to them.

parseMessage was already exported, but users couldn't 'monkey-patch' it to use a different parsing method.

This was users can use their own parser with the help of codes or just simply modify the parser in a different way to their liking.

Has no backwards compat issues either.

@jirwin
Copy link
Collaborator

jirwin commented Jan 11, 2015

@LoveBear codes is already accessible by require('irc/lib/colors')? I perhaps exporting it fromindex.jswould be better so you couldrequire('irc').codes`.

As for parseMessages, I have a plan that would let you have more control over the parsing layer. I'll have that to show soon.

@jirwin
Copy link
Collaborator

jirwin commented Jan 11, 2015

@LoveBear Please take a look at #295 and let me know what you think

@hnry
Copy link
Author

hnry commented Jan 13, 2015

being worked on in #295

@hnry hnry closed this Jan 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants