patch app #10
Open
patch app #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -21,7 +21,7 @@ permillgraph <- function(state, all, capita) { | |||
| if(state == "United States"){ | |||
| if (all) { | |||
| matplot( | |||
| 2000:(as.integer(format(Sys.Date(), "%Y"))-2), | |||
| 2000:2017, | |||
There was a problem hiding this comment.
it looks like you're hard coding to 2017 here -- i think we want to preserve the open end date. the sys.date-2 was a placeholder until we update the FE data to the current date.
| #add full state names | ||
| kdata <- cbind(pop_state_and_us[, 1], kdata) | ||
| colnames(kdata)[1] <- "state_name" | ||
| spread(year, n) %>% |
There was a problem hiding this comment.
spread/gather being replaced by pivot in dplyr, see https://tidyr.tidyverse.org/
| @@ -1,21 +1,21 @@ | |||
| #BM: it's nice for other users if we auto-install missing packages | |||
| #for them | |||
There was a problem hiding this comment.
we should discuss -- would like to make sure i understand how the necessary libraries will be loaded. i'm guessing this is only relevant for running the app locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the app so that it displays correctly with tidyverse and R 4.0 changes