Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename pass_many to pass_collection #2715

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Rename pass_many to pass_collection #2715

merged 2 commits into from
Jan 3, 2025

Conversation

lafrech
Copy link
Member

@lafrech lafrech commented Jan 3, 2025

Closes #1369.

@lafrech lafrech added this to the 4.0 milestone Jan 3, 2025
sloria
sloria approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@sloria sloria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to merge when changelog is updated

@lafrech lafrech changed the base branch from dev to 4.0 January 3, 2025 20:52
@lafrech
Copy link
Member Author

lafrech commented Jan 3, 2025

I just added a changelog line and fixed the target branch.

@sloria sloria merged commit cf9c3a8 into 4.0 Jan 3, 2025
9 checks passed
@sloria sloria deleted the pass_collection branch January 3, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloria sloria sloria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Rename pass_many to pass_collection
2 participants
@lafrech @sloria