Warnings and errors for incompatible use of schema instance and many in fields.Nested #1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafrech
reviewed
Jun 30, 2023
There was a problem hiding this comment.
Thanks for the contribution and sorry about the delay.
I understand the issue. Yet I'm reluctant to add code just to warn about this specific case.
I left a few comments anyway. I might change my mind and accept the test at init. No strong opinion against it.
| if self.many and not self.schema.many: | ||
| raise FieldConfigurationError( | ||
| '"many" may not be used in conjunction with an instance in a nested field.' | ||
| ) |
There was a problem hiding this comment.
I'd remove this test. This should be coverered by the init warning you added above, right?
| many = self.schema.many or self.many | ||
| if many and not utils.is_collection(value): | ||
| raise self.make_error("type", input=value, type=value.__class__.__name__) | ||
| # Check whether many on the nested field and the schema are in conflict. |
There was a problem hiding this comment.
I guess this comment was meant for the change above?
| warnings.warn( | ||
| 'Passing "many" is ignored if using an instance of a schema. Consider fields.List(fields.Nested(...)) instead.', | ||
| FieldConfigurationWarning, | ||
| ) |
|
#779 lists other unexpected edge cases like this. I would rather bite the bullet and deprecate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue I've described in #1982. Behaviour should be unchanged, but more obvious.