[brief] Fixes the build types for Linux.

[detailed] - Also fixes the cache for MSVC so dependencies are built in both debug and release.
marovira · Jun 26, 2024 · 2462e91 · 2462e91
1 parent 967b7af
commit 2462e91
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/build-linux.yml b/.github/workflows/build-linux.yml
@@ -43,7 +43,7 @@ jobs:
           CC: ${{ matrix.config.cc }}
           CXX: ${{ matrix.config.cxx }}
         run: |
-          cmake --preset=$CONFIG_TYPE --config $BUILD_TYPE -DBUILD_SHARED_LIBS=OFF -DCMAKE_PREFIX_PATH=~/deps
+          cmake --preset=$CONFIG_TYPE -DCMAKE_BUILD_TYPE=$BUILD_TYPE -DBUILD_SHARED_LIBS=OFF -DCMAKE_PREFIX_PATH=~/deps
           cd ./build
           make
 

diff --git a/.github/workflows/build-msvc.yml b/.github/workflows/build-msvc.yml
@@ -21,13 +21,13 @@ jobs:
         uses: actions/cache@v4
         with:
           path: C:/deps
-          key: deps-${{ runner.os }}-${{ hashfiles('dependencies.txt') }}
+          key: deps-${{ runner.os }}-${{ matrix.config}}-${{ hashfiles('dependencies.txt') }}
 
       - name: Install dependencies
         if: steps.cache-deps.outputs.cache-hit != 'true'
         shell: powershell
         env:
-          BUILD_TYPE: Release
+          BUILD_TYPE: ${{ matrix.config }}
         run: ./.github/workflows/scripts/install_deps.ps1
 
       - name: Build