Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buggy code related to CONFIG_FORTIFY_SOURCE Kernel versions >4.12 #2

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

Styx85
Copy link

@Styx85 Styx85 commented Dec 28, 2017

This fixes reported compile error #1

Copy link
Owner

@maroviher maroviher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we need some more #else after your #if statement

Copy link
Owner

@maroviher maroviher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we need some more #else after your #if statement regarding to a kernel version check

@maroviher
Copy link
Owner

Your link does not exists (404)

@maroviher
Copy link
Owner

Thanx, I would accept your pull request if you revert "Enable WPA_SUPPLICANT support". I do not want to enable it per default

@Styx85
Copy link
Author

Styx85 commented Dec 30, 2017

reverted wpa supplicant support for you.

@maroviher
Copy link
Owner

I think there is no sense to define usb_buffer_alloc for kernels < 2.6.34, as there are checks in the source code

#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,35)
                                mem->buf = usb_alloc_coherent(bus->root_hub, buf_len, GFP_KERNEL, &mem->data_dma);
#else
                                mem->buf = usb_buffer_alloc(bus->root_hub, buf_len, GFP_KERNEL, &mem->data_dma);
#endif

What does your change MIX_CIPHER_NOTUSE -> WPA_TKIPAES_WPA2_TKIPAES does?

@Styx85
Copy link
Author

Styx85 commented Jan 6, 2018

MIX_CIPHER_NOTUSE -> WPA_TKIPAES_WPA2_TKIPAES

I think this makes it possible to connect to WPA2 AES/TKIP ciphered networks

@Styx85
Copy link
Author

Styx85 commented Jan 6, 2018

I think there is no sense to define usb_buffer_alloc for kernels < 2.6.34, as there are checks in the source code

This should be true and is possible a remnant in the driver because its designed for old kernels.

@Styx85
Copy link
Author

Styx85 commented Jan 6, 2018

And unfortunately I broke my Dongle yesterday with my vacuum cleaner. So I can only build test.

@maroviher
Copy link
Owner

If you are not sure about MIX_CIPHER_NOTUSE -> WPA_TKIPAES_WPA2_TKIPAES, I would not change it.
So if you would discard changes in
common/cmm_mac_usb.c
common/cmm_wpa.c
I would finally merge.

@Styx85
Copy link
Author

Styx85 commented Jan 13, 2018

Should be fine this way

@maroviher
Copy link
Owner

the file chips/rt5592.c has no changes, other than a whitespace, could you please revert it, so that we have only files that were really changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants