-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix buggy code related to CONFIG_FORTIFY_SOURCE Kernel versions >4.12 #2
base: master
Are you sure you want to change the base?
Conversation
…dule kernel version >4.14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we need some more #else after your #if statement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we need some more #else after your #if statement regarding to a kernel version check
Your link does not exists (404) |
Thanx, I would accept your pull request if you revert "Enable WPA_SUPPLICANT support". I do not want to enable it per default |
reverted wpa supplicant support for you. |
I think there is no sense to define usb_buffer_alloc for kernels < 2.6.34, as there are checks in the source code
What does your change MIX_CIPHER_NOTUSE -> WPA_TKIPAES_WPA2_TKIPAES does? |
I think this makes it possible to connect to WPA2 AES/TKIP ciphered networks |
This should be true and is possible a remnant in the driver because its designed for old kernels. |
And unfortunately I broke my Dongle yesterday with my vacuum cleaner. So I can only build test. |
If you are not sure about MIX_CIPHER_NOTUSE -> WPA_TKIPAES_WPA2_TKIPAES, I would not change it. |
Should be fine this way |
the file chips/rt5592.c has no changes, other than a whitespace, could you please revert it, so that we have only files that were really changed |
This fixes reported compile error #1