Place comment identifier at top #1363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
originally The header was in the front. I think it was moved to the footer because it was pointed out that this was a problem when printing in slack. Moving to the head seems difficult to do right now because there are backward compatibility issues, but it seems good to add an option so that you can select it to be output as a footer or header. |
|
Makes sense. Maybe we can wontfix this and instead I’ll propose and PR a patch that bumps the comment to the end of the new message when appending? |
|
That's a good suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1362
Place the comment identifier at the top to keep it from interrupting markdown structures built by appending to the comment, such as tables, which fail with a comment in the middle of them.