Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reworked DirectControlLoop to fix custom values for "maxPwmChangePerCycle" #327

Merged
merged 1 commit into from
Nov 28, 2024
Merged

reworked DirectControlLoop to fix custom values for "maxPwmChangePerCycle" #327

merged 1 commit into from
Nov 28, 2024

Conversation

markusressel
Copy link
Owner

@markusressel markusressel commented Nov 21, 2024 •
edited
Loading

contributes to #326

@markusressel markusressel added the bug Something isn't working label Nov 21, 2024
@markusressel markusressel self-assigned this Nov 21, 2024
@markusressel markusressel mentioned this pull request Nov 21, 2024
Open
@markusressel
Copy link
Owner Author

To avoid having this issue still in production, i will merge this PR now.
Still, I am not 100% sure if the new implementation is what we want and need.
@jwefers If you can spare the time, please come back to this via this PR or the related Issue to comment, thx.

@markusressel markusressel merged commit 087689e into master Nov 28, 2024
1 check passed
@markusressel markusressel deleted the bugfix/#326-maxPwmChangePerCycle-keeps-fan-off branch November 28, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@markusressel markusressel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@markusressel