posix updates #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehesiod
commented
Sep 24, 2016
•
thehesiod
commented
- fixes open/close etc functions
- fixes COND_TIMED_WAIT error value
- makes printfs debug only
- fixes headers for POSIX
- does more error checking on windows methods
- fixes param issues on posix
- does string length checking for temp paths
- adds mq_sendtimed
- correctly marks threaded notifications as not supported
- fixes open/close etc functions - fixes COND_TIMED_WAIT error value - makes printfs debug only - fixes headers for POSIX - does more error checking on windows methods - fixes param issues on posix - does string length checking for temp paths - adds mq_sendtimed
thehesiod
commented
Sep 24, 2016
| int COND_SIGNAL(struct mq_hdr* hdr) | ||
| { | ||
| SetEvent(hdr->mqh_wait); | ||
| return 0; | ||
| BOOL result = SetEvent(hdr->mqh_wait); |
There was a problem hiding this comment.
SetEvent success is non-zero, however pthread_cond_signal is 0 on success, it should match pthread_cond_signal. Of Interested is that the return value is currently not checked
| return ETIMEDOUT; | ||
| } | ||
|
|
||
| return EINVAL; |
There was a problem hiding this comment.
this method needed to return an error value similar to pthread_cond_timedwait
| strcpy(pathBuffer, temp); | ||
| strcat(pathBuffer, pathPart); | ||
| return 1; | ||
| } |
There was a problem hiding this comment.
This now does error checking on the string length
| /* open and specify O_EXCL and user-execute */ | ||
| oflag &= ~3; // strip off RDONLY, WRONLY or RDWR bits | ||
| fd = _open(pathBuffer, oflag | O_EXCL | O_RDWR, mode | S_IXUSR); | ||
| fd = open(pathBuffer, oflag | O_EXCL | O_RDWR, mode | S_IXUSR); |
There was a problem hiding this comment.
need to keep the names posix compatible
| } | ||
|
|
||
| if(n != 0) { | ||
| errno = n; |
There was a problem hiding this comment.
callers expect the errno to be set
| @@ -477,33 +559,36 @@ ssize_t mq_timedreceive(mqd_t mqd, char *ptr, | |||
| errno = EMSGSIZE; | |||
| goto err; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
shouldn't the MUTEX_LOCK above also be timed? If so the same should be done in the timed send
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.