Fix path parameters #266
Merged
Fix path parameters #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markelliot
reviewed
Nov 2, 2023
barista/src/main/java/com/markelliot/barista/endpoints/EndpointRuntime.java
Outdated
Show resolved
Hide resolved
…tRuntime.java Co-authored-by: Mark Elliot <[email protected]>
|
Thanks Mark! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix path parameters for barista annotations.
HttpServerExchanget#getPathParametersis not for path template params, it seems to be for semicolon-separated trailers at the end of the path string. See these tests from when HttpServerExchange#getPathParameters was added to undertow 10 years ago, and also RFC2396cf. path template parsing code in Conjure.
I updated the smoketest to hit a new
openEchoendpoint that receives a path param. The test fails without the change to EndpointRuntime.