Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make trickle multithread version signal safe #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Dec 19, 2013

  1. Make trickle signal safe

    Because, select(),poll(), read(), write() and many other overloaded functions are
    normally reentrant from signal handlers, we need to block all signals while we hold
    mutex or else we can deadlock.
    
    Modified Makefile.am because while make did not build libtrickle.so,
    'make install' was trying to install it. I'm really shooting in the dark for
    autoconf problem so maybe it is not the best way to resolve the problem.
    lano1106 committed Dec 19, 2013
    Configuration menu
    Copy the full SHA
    6dd0aad View commit details
    Browse the repository at this point in the history
  2. Eliminate race condition around oset variable.

    With the help of a set of macros, oset is now an automatic variable
    on the stack of each thread instead of an unprotected global var.
    
    The modif compiles but is not tested yet. I will launch an endurance
    test and report back every few days how things go.
    lano1106 committed Dec 19, 2013
    Configuration menu
    Copy the full SHA
    9172138 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2013

  1. Fix segfault when loading pthread_sigmask symbol.

    Need to be explicit on where to find the symbol. When called, the libpthread may or may not be loaded.
    I have seen segfaut inside the call to safe_vprintf() from errx() when dlsym fail.
    lano1106 committed Dec 23, 2013
    Configuration menu
    Copy the full SHA
    d5f0714 View commit details
    Browse the repository at this point in the history