fix(core): keep duplicate and orphan remappings #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The remappings generation function was not keeping duplicate remappings for a given dependency, and was removing items which could not be matched to an existing dependency. This has been fixed by keeping all existing remappings matching a dependency, and adding back those that do not match one.
beeb
changed the title
beeb
changed the title
mario-eth
approved these changes
Nov 13, 2024
beeb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remappings generation function was not keeping duplicate remappings for a given dependency.
Also, the previous behavior was to remove items which could not be matched to an existing dependency. This was apparently not the desired behavior and has been changed so that they are kept.
A test has been added to prevent regressions.
Closes #225