Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Prometheus Operator Component #32

Closed
wants to merge 3 commits into from

Conversation

sdwilsh
Copy link
Contributor

@sdwilsh sdwilsh commented Oct 7, 2023

No description provided.

@sdwilsh sdwilsh requested a review from robarnold October 7, 2023 04:19
@sdwilsh sdwilsh marked this pull request as ready for review October 7, 2023 04:20
apiVersion: operators.coreos.com/v1alpha1
kind: Subscription
metadata:
name: my-prometheus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never did like the my prefix on names. Can we drop it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure; I guess this should really be something like prometheus-subscription

Comment on lines +7 to +11
spec:
channel: beta
name: prometheus
source: operatorhubio-catalog
sourceNamespace: olm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not being familiar with Prometheus or the operator framework, these lines could use some commenting to explain what they do and how to customize them (if possible, necessary), or perhaps docs on the operator framework component itself.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is taken verbatim from the install instructions on https://operatorhub.io/operator/prometheus

The operatorhubio-catalog is part of the olm installation, which lives in the olm namespace.

@sdwilsh
Copy link
Contributor Author

sdwilsh commented Nov 30, 2023

We are not using OLM now, so this goes bye-bye

@sdwilsh sdwilsh closed this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants