-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Prometheus Operator Component #32
Conversation
apiVersion: operators.coreos.com/v1alpha1 | ||
kind: Subscription | ||
metadata: | ||
name: my-prometheus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never did like the my prefix on names. Can we drop it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure; I guess this should really be something like prometheus-subscription
spec: | ||
channel: beta | ||
name: prometheus | ||
source: operatorhubio-catalog | ||
sourceNamespace: olm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not being familiar with Prometheus or the operator framework, these lines could use some commenting to explain what they do and how to customize them (if possible, necessary), or perhaps docs on the operator framework component itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is taken verbatim from the install instructions on https://operatorhub.io/operator/prometheus
The operatorhubio-catalog
is part of the olm installation, which lives in the olm
namespace.
We are not using OLM now, so this goes bye-bye |
No description provided.