Fix CONC-396, "!includedir in my.cnf does not include all .cnf and .ini files in the directory" #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!includedir now includes all .cnf files in the specified directory. A fix for Windows has been added but is untested.
_mariadb_read_options_from_file now uses wildcards for each config file extension instead of inspecting every filename in the included directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix the issue CONC-396. Previously,
_mariadb_read_optionsand_mariadb_read_options_from_filewould only read options from files namedmy.cnfwithin the specified directory when the!includedirdirective was encountered. With these changes, the functions find all.cnf(and, on Windows,.ini) files in the included directory.