Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local javascript #35

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Local javascript #35

wants to merge 8 commits into from

Conversation

havet
Copy link
Contributor

@havet havet commented Jan 26, 2016

Local javascript for better security, reliability and speed.

havet added 8 commits January 24, 2016 19:09
Added an option to store the passwords in hashed form.
Added missing lines in the Swedish translation.
Changed to national characters.
Changed some comments.
The jquery javascript file now in a local folder for better security,
reliability and performance.
Now copied the right files.
@marekrei
Copy link
Owner

Hi havet!
Thanks for the contribution. But I don't think it's a good idea to switch to using local javascript files.
The main goal of this script is that it's only a single file - easy to use and causes minimal clutter in the server. I can see scenarios where local javascript is preferable, but this is not the target audience for this script.

@havet
Copy link
Contributor Author

havet commented Feb 19, 2016

Hi!
You've got a point.
Doesn't improve security that much anyway.
The character conversion is important, on the other hand. Now all file names are distorted.
And have a look at The translation to swedish in my first pull request.

Yours,
Per
Skickat från min Sony Xperia™-smartphone

---- Marek Rei skrev ----

Hi havet!
Thanks for the contribution. But I don't think it's a good idea to switch to using local javascript files.
The main goal of this script is that it's only a single file - easy to use and causes minimal clutter in the server. I can see scenarios where local javascript is preferable, but this is not the target audience for this script.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants