Bazel support #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a mega commit that converts the project over to be built by Bazel. There isn't a terribly good reason to do this other than how it's a build system that was made in the last 40 years. This involved lots of BUILD file additions and updating header file paths. Things left to do still: - Cflags: `-O3 -Wall -fopenmp` - Update the README with Bazel instructions
I prefer the fully qualified forms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent some time converting the project to use Bazel. I ran into some issues
that I couldn't fix and decided it would give the project a higher barrier to
entry so I ultimately decided to ditch it. I don't love Make but at least it's very
well known and works just about everywhere. It's also easy to tweak the settings
to work on any particular machine. I'm going to leave this pull open in case
somebody wants to continue working on it.
The issues:
out of date.
what determines which compiler is used on a given machine. I can create a
CROSSTOOL but that's a huge amount of effort and probably won't be cross platform
anyway.