Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Github history of each one of the files in this extension package is a monument to over a decade of community development, and I think that's kind of beautiful. On the other hand, shipping a massive amount of unused, obsolete javascript code that's up to a decade old is, like, you know... bad. (For review, for performance, etc.)
This implements a small tweak to the extension load code that'll make a commented-out file mostly a no-op. This facilitates the use of block comments to relatively easily remove large swathes of javascript from our reviewable, executable codebase while preserving the per-line git history and making re-enabling commented code (e.g. to update it or to revert an accidental comment) extremely easy.
(I have not at time of writing gone through to see which extensions should be commented and which are still usable on legacy pages and should thus stay; I don't think our documentation or the colors applied in
xkit_preferences.css
are entirely without error.)