sqlite unique primary key generation bug #155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ict), this "conflict" value is set initially to false value before loop start and does not change in loop body, loop will repeate itself only if condition is true, but condition is hardcoded false and will exit after first iteration without any conditions, which in turn leads to potential generation of nonunique primary keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"continue" statement forces loop condition re-evaluation - while(conflict), this "conflict" value is initialized to false and does not change inside of loop body (loop will repeat itself only if condition is true, but condition is hardcoded false and will exit after first iteration) - loop will execute only once even if non unique primary key was generated, which will result in a sqlite crash (unique pk assertion failure)