Skip to content

Commit

Permalink
Bug 1862032 [wpt PR 42811] - Revert recent changes to inheritance of …
Browse files Browse the repository at this point in the history
…direction and language for <slot> elements., a=testonly

Automatic update from web-platform-tests
Revert recent changes to inheritance of direction and language for <slot> elements. (#42811)

This changes the way <slot> elements inherit the HTML concepts of
direction and language to inherit from their parent, rather than from
their shadow root's host.

This matches the changes that I'm proposing in:
whatwg/html#9880

These changes are all behind flags that are slated to ship in M120:
CSSPseudoDir for the direction changes and HTMLLangNewInheritance for
the language changes.

Bug: 576815, 1490711
Change-Id: I152d8e21e24e77c9359744019b3ab875c2a21727
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4984312
Reviewed-by: Di Zhang <dizhanggchromium.org>
Commit-Queue: David Baron <dbaronchromium.org>
Cr-Commit-Position: refs/heads/main{#1216286}

Co-authored-by: L. David Baron <dbaronchromium.org>
--

wpt-commits: e873a33f5a8564beb3864cb779e0c774aa4816c7
wpt-pr: 42811

UltraBlame original commit: 7b03de6bdb3af4238f001a4b2d9016c2add83044
  • Loading branch information
marco-c committed Nov 21, 2023
1 parent fc9a8f1 commit 351adb6
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 22 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -295,10 +295,10 @@
value
for
the
span
slot
is
:
rtl
ltr
/
ltr
.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@
value
for
the
span
slot
is
:
<
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@
>
dir
=
ltr
rtl
on
a
div
Expand All @@ -243,7 +243,7 @@
tree
dir
=
rtl
ltr
on
the
shadow
Expand Down Expand Up @@ -271,24 +271,19 @@
dir
=
"
rtl
ltr
"
>
<
div
dir
=
"
ltr
rtl
"
>
<
span
dir
=
"
rtl
"
>
<
/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@
>
dir
=
ltr
rtl
on
a
div
Expand All @@ -282,7 +282,7 @@
tree
dir
=
rtl
ltr
on
the
shadow
Expand Down Expand Up @@ -310,7 +310,7 @@
dir
=
"
rtl
ltr
"
>
<
Expand Down Expand Up @@ -386,7 +386,7 @@
dir
=
"
ltr
rtl
"
>
<
Expand Down Expand Up @@ -427,7 +427,7 @@
[
dir
=
ltr
rtl
]
"
)
Expand All @@ -450,7 +450,7 @@
[
dir
=
ltr
rtl
]
"
)
Expand All @@ -475,7 +475,7 @@
[
dir
=
ltr
rtl
]
"
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -416,8 +416,7 @@ on
slot
inherits
from
shadow
host
parent
"
light_tree
:
Expand Down Expand Up @@ -502,7 +501,7 @@ expected
"
en
-
GB
CA
"
>
<
Expand Down

0 comments on commit 351adb6

Please sign in to comment.