Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(bash): Add a bunch of tests for bash special characters. #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(bash): Add a bunch of tests for bash special characters. #25

wants to merge 1 commit into from
+90 −21

Conversation

JeffFaer
Copy link
Contributor

Right now, these tests fail. They will pass after spf13/cobra#2126 has been merged.

This PR is based on top of #24

@JeffFaer JeffFaer mentioned this pull request Oct 30, 2024
Open
@marckhouzam
Copy link
Owner

I’m trying to look into this one, but I’m having docker issues. Some update site is down right now. I’ll try again later on.

marckhouzam
marckhouzam reviewed Nov 4, 2024
View reviewed changes
Copy link
Owner

@marckhouzam marckhouzam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've merged #24, so you can rebase this on the new main

@JeffFaer
Copy link
Contributor Author

JeffFaer commented Nov 8, 2024

I've merged #24, so you can rebase this on the new main

Done!

@marckhouzam
Copy link
Owner

@JeffFaer Could you sign-ff the two last commits, or else the DCO check fails.

marckhouzam
marckhouzam reviewed Nov 18, 2024
View reviewed changes
testprog/testprog.go Outdated Show resolved Hide resolved
tests/bash/comp-tests.bash Outdated Show resolved Hide resolved
tests/bash/comp-test-lib.bash Show resolved Hide resolved
tests/bash/comp-tests.bash Outdated Show resolved Hide resolved
@JeffFaer JeffFaer force-pushed the special_characters branch 2 times, most recently from a6e57de to 2810560 Compare December 5, 2024 04:38
@JeffFaer JeffFaer requested a review from marckhouzam December 5, 2024 04:38
@marckhouzam
Copy link
Owner

marckhouzam commented Dec 27, 2024 •
edited
Loading

I've pushed a new commit to this PR to help in testing: 14557ce

@marckhouzam
Copy link
Owner

@JeffFaer I'm almost ready to merge this but one of your commit does not have the "Signed-off-by" and fails the DCO check. Could you fix that and push it back please?

@marckhouzam
Copy link
Owner

@JeffFaer I have pushed a commit on top of yours which adds some tests for special-characters when using completion descriptions.

I'm happy with this PR and will merge as soon as you can repush it to properly add the signed-off to your commit.
Actually, if you can squash all your commits into one, that would be even better.

@marckhouzam marckhouzam mentioned this pull request Jan 18, 2025
Open
@JeffFaer
Copy link
Contributor Author

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marckhouzam marckhouzam Awaiting requested review from marckhouzam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeffFaer @marckhouzam