Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix single node #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BenedictBoyle
Copy link

Ran into a few issues when using this very handy module:

  1. When dumping very simple dicts like {'a', 'b'} you get an error, in fact there's no way to get an output of <a>b</a> even using _value keys.
  2. When dumping a dict, the code strips the _attrs keys from the underlying dict, so dumping the same dict more than once gives different results (no attributes on subsequent dumps).

These minor amendments should address both of these issues - I've included test cases for both.

Many thanks.

…w nodes and preserving attributes across repeated dumps. Tests included
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant