-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to gen.coroutine #42
base: master
Are you sure you want to change the base?
Conversation
@@ -32,6 +33,9 @@ | |||
class CollectionMetaClass(type): | |||
|
|||
def __new__(cls, name, bases, attrs): | |||
if not attrs.get('__collection__'): | |||
attrs['__collection__'] = re.sub( | |||
'([A-Z]+)', r'_\1', name).lower()[1:] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct but normal upper-camel-case class names, but omits first character if class name starts with lower-case letter.
I reviewed the changes, most of them seems OK, but this notes should be considered:
|
I do not understand about |
Yes, I was wrong about |
when call hasattr(self, '_initialized') with not initialized database
@tahajahangir could you please fix two tests in |
when default is not specified but min or max value is specified you got a validation error
I rebased the changes to add travis build support. The new branch is located in I fixed the two failing tests in orm.signals (they incorrectly used two nested stop/wait calls). The good news is tests are passing in python 2.7, and the bad news is they passed only on python 2.7 (failed in 2.6, 3.2, 3.3, 3.4 and pypy). Build results is accessible in https://travis-ci.org/tahajahangir/mongotor/builds/26819709 . @marcelnicolay : What's the reason to fix versions in @geerk : Can you fix syntax errors on python 2.6? (see build status) |
@tahajahangir why we should support 2.6? I think those who use Tornado and MongoDB will not use 2.6. |
I added some commits (mainly added use of six and removed use of sure) and tests now run on python 2.7/3.2/3.3/3.4 (build status) Only one test is failing on python 2.6. On pyy, there are several failing tests, and test process stucks at I also pushed a merge of current open pull requests (#42 #42 #44 #37) to tahajahangir/master |
No description provided.