Change removed navigationControl to zoomControl and panControl. #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi cyberhobo,I have implemented your new code, and works great, forget my last comment.Thanks. |
I believe this is what the former navigationControl option did.
|
This fix works for me. 👍 to merging it |
henare
pushed a commit
to openaustralia/planningalerts
that referenced
this pull request
Jan 13, 2014
* master: Upgrade to ruby-2.0.0-p247 Add test for html email for authority comment notification. Include test for multiple paragraphs Update newrelic agent for extra features Use maps client id if it is available for maps api use Move list of assets to precompile over to application.rb so it is available even when production.rb is overridden Actually make it possible to use maps api v3 in production Use google maps api v3 (via mapstraction) and add satelite option to map Applied fix for googlev3 controls not showing from mapstraction/mxn#257 Updated to Mapstraction v 2.0.18 (and added googlev3 support) don't need our own backported geokit anymore. Can use a release version Conflicts: config/environments/production.rb
JWells
pushed a commit
to JWells/planningalerts-app
that referenced
this pull request
Feb 22, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #253, and should repair the broken methods
addControls(),addLargeControls(), andaddSmallControls(), as well as the global loadoptions.addControlArgs initialization variable for zoom and pan controls.In
tests/core.html, action 12 "Add Controls" should work again.