Make the user pass in a WebRTC implementation (for #7) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @paulkernfeld, thanks for contributing! Although I should let you know that a lot of the code inside this repo is already being moved into smaller repos, see the roadmap in the README for links. |
|
Ah, okay, now I see that this is approach is already implemented in peerGroup in bitcoin-net for example, so that will make this PR obsolete soon. Do you have an ETA for finishing the refactor? |
I'm looking to get it done ASAP, but I'm bad at time estimates. Maybe 3 or 4 days of work. #13 |
|
Nice! That's super fast, so it's probably not worth it to merge this PR. |
|
Closing because this feature is in |
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this change isn't too invasive. This seemed like the most straightforward way to do it.
Also a quick note that this is a breaking change.