Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group symbolizer reference #61

Closed
wants to merge 3 commits into from

Conversation

hollinger
Copy link
Member

This adds reference information for group symbolizer (mapnik/mapnik#2160). The goal is to be able to create group symbolizers in Carto CSS. This effort also requires a corresponding update to carto (mapbox/carto#349).

See https://github.com/mapnik/mapnik/wiki/GroupSymbolizer for more information on group symbolizer.

@springmeyer
Copy link
Member

planning on reviewing and testing this soon. Let me know if it needs any updates or if its still ready to go from your perspective.

"serialization": "rules",
"tag-name": "GroupRule",
"doc": "Class names, seperated by spaces, to be used for matching style definitions to the group symbolizer."
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure that the above two attributes belong here in mapnik reference, because they do not correspond directly with options used by mapnik. The 'group-name' and 'group-class' css options are really aimed at the carto compiler, which will use the name and class just like a layer to build rules and symbolizers that go inside of the group symbolizer. I included them here mostly for simpler validation in carto.

@hollinger
Copy link
Member Author

The fact that a group symbolizer can contain a whole set of rules and symbolizers is somewhat tricky to represent in the reference json and in carto syntax. It is possible that there could be a better solution than what I have here.

The concept of using child elements to define layout, format, and placement nodes was introduced in #62. If we go with that approach, it could possibly be extended to define the contents of group symbolizer. It might be better to get the work in #62 finalized before merging this.

springmeyer pushed a commit that referenced this pull request Jan 14, 2015
springmeyer pushed a commit to mapbox/carto that referenced this pull request Jan 14, 2015
@pnorman
Copy link
Contributor

pnorman commented Nov 25, 2015

Any additional changes to this PR are probably going to have to be done by the Mapnik team, not @hollinger

nebulon42 pushed a commit to nebulon42/mapnik-reference that referenced this pull request Feb 19, 2016
@springmeyer springmeyer closed this Mar 5, 2016
@springmeyer springmeyer mentioned this pull request Mar 5, 2016
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants