Add list placement to text and shield symbolizers from 2.1.0 onwards. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
References mapnik#45 Enables a CartoCSS workaround - see mapbox/carto#238 (comment)
|
Can you add docs as well? Ideally describe in a concise why what the |
|
bump @gravitystorm - happy to merge this once docs are in place. Let me know what you think. |
springmeyer
pushed a commit
that referenced
this pull request
Feb 7, 2014
Add list placement to text and shield symbolizers from 2.1.0 onwards.
|
docs still missing, but merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's still the outstanding problem of how to describe the different placements, but since this enables advanced users to use a workaround, it's still useful. At the very least, this documents what these advanced users need to edit to get things working!
References (but doesn't fully fix) #45
Enables a CartoCSS workaround - see
mapbox/carto#238 (comment)