Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the location manager being nil after Swiftui view update. #57

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

engali94
Copy link
Contributor

@engali94 engali94 commented Oct 17, 2024

Issue/Motivation

Fixed the location manager being nil after Swiftui view update.

Tasklist

  • Include tests (if applicable) and examples (new or edits)
  • If there are any visual changes as a result, include before/after screenshots and/or videos
  • Add #fixes with the issue number that this PR addresses
  • Update any documentation for affected APIs
  • Update the CHANGELOG

@Archdoog
Copy link
Collaborator

This looks fine to me 👍

@ianthetechie ianthetechie added the release:patch Performs an automatic patch version release on merge label Oct 22, 2024
Copy link
Collaborator

@ianthetechie ianthetechie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies for letting this go 5 days without a review 😅 I must have missed the GitHub notification. LGTM as well after CI passes.

@ianthetechie ianthetechie merged commit a6e079c into maplibre:main Oct 22, 2024
2 checks passed
engali94 added a commit to engali94/swiftui-dsl that referenced this pull request Nov 3, 2024
ianthetechie added a commit that referenced this pull request Nov 11, 2024
#59)

* Revert "Fix the location manager being nil after Swiftui view update. (#57)"

This reverts commit a6e079c.

* Update CHANGELOG.md

---------

Co-authored-by: Ian Wagner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Performs an automatic patch version release on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants