Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/map camera and layer mods #12

Merged
merged 5 commits into from
Jan 2, 2024
Merged

Feat/map camera and layer mods #12

merged 5 commits into from
Jan 2, 2024

Conversation

Archdoog
Copy link
Collaborator

  • Upgrades MapLibre.xcframework.
  • Adds builders to MapViewContentBuilder.
  • Moves MapViewContentBuilder to DSL package to allow StyleLayerCollection (avoids circular dependency).
  • Creates CameraState
  • Enhances MapViewCamera to allow state user "intent" handling. E.g. the MapViewCamera binding could be handled/tracked in ferrostar core or the NavigationMapView allowing the user to showcase the route, pan/free browse, or jump back to the snapped location.

ianthetechie
ianthetechie requested changes Dec 26, 2023
View reviewed changes
Copy link
Collaborator

@ianthetechie ianthetechie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Mostly minor changes requested.

Sources/MapLibreSwiftUI/Models/MapCamera/MapViewCamera.swift Outdated Show resolved Hide resolved
Sources/MapLibreSwiftUI/Models/MapCamera/CameraState.swift Outdated Show resolved Hide resolved
Sources/MapLibreSwiftUI/MapView.swift Outdated Show resolved Hide resolved
Sources/MapLibreSwiftUI/MapView.swift Outdated Show resolved Hide resolved
Sources/MapLibreSwiftUI/Examples/Camera.swift Outdated Show resolved Hide resolved
Sources/MapLibreSwiftUI/MapView.swift Outdated Show resolved Hide resolved
Sources/MapLibreSwiftUI/Examples/Camera.swift Show resolved Hide resolved
ianthetechie
ianthetechie approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@ianthetechie ianthetechie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thanks!

@ianthetechie ianthetechie merged commit 14da8c2 into maplibre:main Jan 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianthetechie ianthetechie ianthetechie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Archdoog @ianthetechie