feat: enable zoneless app

[n-elhk]

Update to Angular 18.2.5

Add ChangeDetection.OnPush to all demo components

Replace provideZoneChangeDetection by provideExperimentalZonelessChangeDetection()

Use signal to update the template

[HarelM]

Can you please split this PR into different PRs, each with a smaller scope?
If there are lint changes for example that are done automatically then reviewing is not interesting, so if not every bullet above as a separate PR, then at least the automatic stuff.
THANKS!

[n-elhk]

so if not every bullet above as a separate PR, then at least the automatic stuff.

I can split it into 3 Prs this way:

1st: update node version

2nd: update angular version

3rd: the rest

[HarelM]

No need to update node as node 22 is not the current latest stable version.
Lint (change quote between single and double) should be a different PR.
I just recently updated the Angular version see

• Update angular to latest alongside other packages #187

So I would focus on a PR that only enables zoneless app.

[HarelM]

Is this your IDE setting that is setting the "for" and the "if" in the same line?
I don't think it adds readability...

[marcjulian]

I also have the same formatting issue with VSCode in this project. It wont format the new Angular Control Flow syntax correctly and also changes single quotes to double for me as well. How to you format the code?

I usually use prettier for formatting

[HarelM]

I usually prefer lint, although usually not as powerful, it gets the job done.

[n-elhk]

Hello @HarelM @marcjulian

I have a warning in the path 'demo/add-image-missing-generated'.

This warning is triggered when I replace 'provideZoneChangeDetection' with 'provideExperimentalZonelessChangeDetection'.

The 'maplibre-gl' package raises this warning:

I investigated and here's what I found:
when initializing the mgl-layer component with the init() method, the addLayer function is used and this causes this warning.

Do you have any idea how to solve this problem ?

[HarelM]

Are you sure the styleimagemissing event is triggered and the img-layer is created to add an image to the map and thus avoid this warning?
It looks like the image is not added to the map, or maybe added asynchronously thus maplibre-gl is complaining that the image is missing...

[n-elhk]

Are you sure the styleimagemissing event is triggered and the img-layer is created to add an image to the map and thus avoid this warning? It looks like the image is not added to the map, or maybe added asynchronously thus maplibre-gl is complaining that the image is missing...

Yes, the styleimagemissing event is triggered and the images are displayed correctly.

[HarelM]

It might be a timing issue then, not sure...
The following is the same example, but without the angular wrapper - this seems to work without console warning or errors:
https://maplibre.org/maplibre-gl-js/docs/examples/add-image-missing-generated/

[HarelM]

@n-elhk can you please take a look at the issues that are open, I think the migration to signals introduced some issues especially with removed destroy methods.
It is best to make sure that everything is working as it did before, before rushing to integrate new features.