Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename homebrew formula subdirctory #923

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Conversation

sharkAndshark
Copy link
Collaborator

Rename hombrew formula directory from homebrew-formula to HomebrewFormula based on the homebrew doc.

@sharkAndshark sharkAndshark marked this pull request as draft October 7, 2023 09:56
@sharkAndshark sharkAndshark changed the title Rename homebrew formula subdirctory WIP Rename homebrew formula subdirctory Oct 7, 2023
@sharkAndshark
Copy link
Collaborator Author

sharkAndshark commented Oct 8, 2023

I made a test on my M1 Mac. I could install martin on it after this change.
Before this change:

brew tap maplibre/martin https://github.com/maplibre/martin.git
brew install maplibre/martin/martin
Warning: No available formula or cask with the name "maplibre/martin/martin".

After this change:

brew tap maplibre/martin https://github.com/maplibre/martin.git
brew install maplibre/martin/martin
==> Fetching dependencies for maplibre/martin/martin: openssl@3
==> Fetching openssl@3
==> Downloading https://ghcr.io/v2/homebrew/core/openssl/3/manifests/3.1.3
######################################################################### 100.0%
==> Downloading https://ghcr.io/v2/homebrew/core/openssl/3/blobs/sha256:297a2c1c
######################################################################### 100.0%
==> Fetching maplibre/martin/martin
...
==> Summary
🍺  /opt/homebrew/Cellar/martin/0.8.7: 3 files, 13.2MB, built in 3 seconds
==> Running `brew cleanup martin`...
Disable this behaviour by setting HOMEBREW_NO_INSTALL_CLEANUP.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).
==> Caveats
==> martin
Martin requires a database connection string.
It can be passed as a command-line argument or as a DATABASE_URL environment variable.
  martin postgres://postgres@localhost/db

@sharkAndshark sharkAndshark changed the title WIP Rename homebrew formula subdirctory Rename homebrew formula subdirctory Oct 8, 2023
@sharkAndshark sharkAndshark requested a review from nyurik October 8, 2023 01:31
@sharkAndshark sharkAndshark marked this pull request as ready for review October 8, 2023 01:31
@sharkAndshark
Copy link
Collaborator Author

Hi @nyurik Have a good day :)
Any idea about automatically update the version number in formula in ci. How about shell command to retrieve version info from cargo.toml?

Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! I keep thinking if it would make sense to create a separate repository just for this, and automate its update with a github action... But that would be a separate PR

@nyurik nyurik merged commit eaee56c into maplibre:main Oct 8, 2023
24 checks passed
@sharkAndshark sharkAndshark deleted the homebrew branch March 14, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants